Deprecation path advancement#1748
Open
rpspringuel wants to merge 2 commits intogregorio-project:developfrom
Open
Deprecation path advancement#1748rpspringuel wants to merge 2 commits intogregorio-project:developfrom
rpspringuel wants to merge 2 commits intogregorio-project:developfrom
Conversation
Remove OBSOLETE code Code which was DEPRECATED in the background (i.e. pending modification of executable) is modified. This really should have been done for 6.2 (since we modified the executable in that release), but was overlooked.
rpspringuel
added a commit
to rpspringuel/gregorio-test
that referenced
this pull request
Apr 19, 2026
| clef = score->first_voice_info->initial_clef; | ||
| } | ||
| /* After removing deprecated arguments, this will become: | ||
| fprintf(f, "\\GreBeginScore{%s}{%s}{%u}{}%%\n", |
Contributor
There was a problem hiding this comment.
If the fourth argument is always empty, why not remove it as well? (I know I wrote this line, but I don't remember the reason.)
Contributor
Author
There was a problem hiding this comment.
We probably should remove it. I can't find anything in the codebase that indicates that the empty argument is still used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove OBSOLETE code
Code which was DEPRECATED in the background (i.e. pending modification of executable) is modified. This really should have been done for 6.2 (since we modified the executable in that release), but was overlooked.